refactor: remove swap findChildren #2077
Merged
+202
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
26aa974 to
e9360fd
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
e9360fd to
ee37dc9
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
ee37dc9 to
c4c27e3
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
c4c27e3 to
fce4b4c
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
fce4b4c to
875db96
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
875db96 to
4d6f156
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
eb1bdff to
d63a75d
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
d63a75d to
1896058
Compare
alessey
force-pushed
the
alessey/remove-swap-findChildren
branch
from
1896058 to
6b7557f
Compare
brendan-defi
reviewed
Mar 5, 2025
| maxSlippage: defaultMaxSlippage || FALLBACK_DEFAULT_MAX_SLIPPAGE, | ||
| }} | ||
| isSponsored={isSponsored} | ||
| headerLeftContent={<div>test</div>} |
There was a problem hiding this comment.
yea, I will be removing these playground updates prior to merging, but wanted to make it easy to test the different permutations.
brendan-defi
reviewed
Mar 5, 2025
| token={ethToken} | ||
| type="from" | ||
| <div className="relative flex flex-col gap-6"> | ||
| <h2>Swap Default</h2> |
There was a problem hiding this comment.
since you're adding a default here, should we remove SwapDefault from the dropdown?
brendan-defi
previously approved these changes
Mar 5, 2025
dschlabach
previously approved these changes
Mar 6, 2025
dschlabach
approved these changes
Mar 6, 2025
cpcramer
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Update Swap and SwapSettings components to have default children. Added toToken, fromToken, swappableTokens as top level props when children is undefined. Interface is unchanged when children are passed in.
Notes to reviewers
How has it been tested?